Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acid runner cannot get acid stacks from nested humans #3772

Merged
merged 8 commits into from
Jul 9, 2023

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Jun 30, 2023

About the pull request

If a human is in a nest, the acid runner won't get any acid from it
If a human is stage 4 or 5 (about to burst), the runner won't get acid either, to prevent circumventing the above change.

Explain why it's good for the game

It's against the rules anyways

Changelog

🆑
add: Acid runners don't get acid from slashing nested humans
add: Very late-stage marines do not give acid
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 30, 2023
@ihatethisengine
Copy link
Contributor

Nothing mechanically stops you from unnesting them. Maybe a better solution would be to not give acid stacks from hugged or late stage hugged?

@BeagleGaming1
Copy link
Contributor Author

Nothing mechanically stops you from unnesting them. Maybe a better solution would be to not give acid stacks from hugged or late stage hugged?

Probably a good idea, I'm gonna do this later or in another pr if I forget

@Diegoflores31
Copy link
Contributor

Nothing mechanically stops you from unnesting them. Maybe a better solution would be to not give acid stacks from hugged or late stage hugged?

No more benefits to combat hugged marines please

@BeagleGaming1
Copy link
Contributor Author

Nothing mechanically stops you from unnesting them. Maybe a better solution would be to not give acid stacks from hugged or late stage hugged?

No more benefits to combat hugged marines please

It's only stage 4 and 5, which by that point the marine is moments from bursting

@Diegoflores31
Copy link
Contributor

Nothing mechanically stops you from unnesting them. Maybe a better solution would be to not give acid stacks from hugged or late stage hugged?

No more benefits to combat hugged marines please

It's only stage 4 and 5, which by that point the marine is moments from bursting

I think with them not winning acid while nested is enought . Nobody will unnest just to get 100 acid and even if they did it would be against rules

@ihatethisengine
Copy link
Contributor

Bro the point is to replace the rule with this mechanical limitation. And yeah, before the rule runners already had to unnest their victims to get stacks, because wall nesting wasn't a thing back then.

Also it doesn't buff hugged marines, they still get acided. Just runners don't get acid stacks from them.

@Diegoflores31
Copy link
Contributor

Bro the point is to replace the rule with this mechanical limitation. And yeah, before the rule runners already had to unnest their victims to get stacks, because wall nesting wasn't a thing back then.

Also it doesn't buff hugged marines, they still get acided. Just runners don't get acid stacks from them.

Uh no? The rule is still in place and will remain . This is just something added on top of that you cannot kill captures unless hive is getting sieged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 9, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works; and yes at least stage 4 is required for this to have any effect. Stage 5 is basically 1 second from pop. IMO having an embryo at all should be grounds to not gain acid stacks, but we can push the stage level even lower in the future if needed.

@Drulikar Drulikar added this pull request to the merge queue Jul 9, 2023
Merged via the queue into cmss13-devs:master with commit 69a7e7a Jul 9, 2023
github-actions bot added a commit that referenced this pull request Jul 9, 2023
cm13-github added a commit that referenced this pull request Jul 9, 2023
@BeagleGaming1 BeagleGaming1 deleted the acid-runner branch September 15, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants